DLocal: update the phone and ip fields #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreiff
requested changes
Jun 7, 2024
yunnydang
force-pushed
the
d_local_update_ip_and_phone_fields
branch
from
1fd4cea
to
71c953a
Compare
yunnydang
changed the title
yunnydang
force-pushed
the
d_local_update_ip_and_phone_fields
branch
from
71c953a
to
23169a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the top level
ipandphonefields to correctly be mapped.Note: the
onboarding_ip_addressis actually supposed to be within theaddtional_risk_dataobject according to DLocals documention. Unsure why we were trying to set it as theipfield prior, but it wasn't being used correctly.Local:
5932 tests, 79858 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
46 tests, 202 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
40 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed