NMI: Adding GooglePay and ApplePay #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinourain
approved these changes
Jun 14, 2024
javierpedrozaing
force-pushed
the
SER-1295-nmi_add_google_and_apple_pay
branch
from
ed3d022
to
a2b2499
Compare
Heavyblade
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Looks pretty much ok @javierpedrozaing, left a comment just prevent possible issues with current customers (NMI have tone of transactions)
javierpedrozaing
force-pushed
the
SER-1295-nmi_add_google_and_apple_pay
branch
from
a2b2499
to
14aff92
Compare
Description ------------------------- This commit add support to create transaction with GooglePay and ApplePay. This payment methods are working for nmi_secure. Unit test ------------------------- Finished in 11.283174 seconds. 59 tests, 475 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 5.23 tests/s, 42.10 assertions/s Remote test ------------------------- Finished in 115.513346 seconds. 55 tests, 199 assertions, 12 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 78.1818% passed 0.48 tests/s, 1.72 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected
javierpedrozaing
force-pushed
the
SER-1295-nmi_add_google_and_apple_pay
branch
from
14aff92
to
82fe7c4
Compare
naashton
approved these changes
Jul 12, 2024
Comment on lines
+195
to
+196
| post[:decrypted_applepay_data] = 1 | ||
| post[:decrypted_googlepay_data] = 1 |
There was a problem hiding this comment.
Do both of these need to be set to 1 regardless of which payment method type is being used?
There was a problem hiding this comment.
Hi @naashton base on the NMI docs yes, for both cases set 1 to indicate decrypted data is being sent.
javierpedrozaing
added a commit
that referenced
this pull request
Jul 25, 2024
Description ------------------------- This commit add support to create transaction with GooglePay and ApplePay. This payment methods are working for nmi_secure. Unit test ------------------------- Finished in 11.283174 seconds. 59 tests, 475 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 5.23 tests/s, 42.10 assertions/s Remote test ------------------------- Finished in 115.513346 seconds. 55 tests, 199 assertions, 12 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 78.1818% passed 0.48 tests/s, 1.72 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
javierpedrozaing
added a commit
that referenced
this pull request
Jul 25, 2024
Description ------------------------- This commit add support to create transaction with GooglePay and ApplePay. This payment methods are working for nmi_secure. Unit test ------------------------- Finished in 11.283174 seconds. 59 tests, 475 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 5.23 tests/s, 42.10 assertions/s Remote test ------------------------- Finished in 115.513346 seconds. 55 tests, 199 assertions, 12 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 78.1818% passed 0.48 tests/s, 1.72 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit add support to create transaction with GooglePay and ApplePay.
This payment methods are working for nmi_secure.
SER-1295
Unit test
Finished in 11.283174 seconds.
59 tests, 475 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
5.23 tests/s, 42.10 assertions/s
Remote test
Finished in 115.513346 seconds.
55 tests, 199 assertions, 12 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
78.1818% passed
0.48 tests/s, 1.72 assertions/s
Rubocop
798 files inspected, no offenses detected