Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credorax: Update 3DS version mapping #5159

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

almalee24
Copy link

Update so that if a 3DS version starts with 2 it doesn't default to 2.0 but on what is passed in for the three_ds_version field.

Unit:
82 tests, 394 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote:
51 tests, 173 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 88.2353% passed

@almalee24 almalee24 requested a review from a team July 1, 2024 20:23
Copy link
Contributor

@bradbroge bradbroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Update so that if a 3DS version starts with 2 it doesn't
default to 2.0 but on what is passed in for the three_ds_version
field.

Unit:
82 tests, 394 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
51 tests, 173 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
88.2353% passed
@almalee24 almalee24 force-pushed the update_credorax_3ds_version branch from bad0ffa to 4f34933 Compare July 10, 2024 14:53
@almalee24 almalee24 merged commit 4f34933 into master Jul 10, 2024
5 checks passed
@almalee24 almalee24 deleted the update_credorax_3ds_version branch July 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants