Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexCharge: Adding authorize-capture functionality #5163

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Heavyblade
Copy link
Collaborator

Summary:

Changes FlexCharge to add support for the authorize and capture operations and also a fix a bug on the address_names method

SER-1337
SER-1324

Testing

Remote Test:

Finished in 72.283834 seconds.
19 tests, 54 assertions, 1 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
94.4444% passed

Unit Tests:

Finished in 43.11362 seconds.
5944 tests, 79908 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:

798 files inspected, no offenses detected

@Heavyblade Heavyblade force-pushed the SER-1324_Addign_Authorize_functionality branch 3 times, most recently from 17ba21a to fa45d27 Compare July 3, 2024 16:37
@Heavyblade Heavyblade requested a review from naashton July 3, 2024 17:03
@Heavyblade Heavyblade force-pushed the SER-1324_Addign_Authorize_functionality branch from fa45d27 to db57ae3 Compare July 3, 2024 21:04
Copy link
Contributor

@sinourain sinourain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job, just a couple of comments :)

lib/active_merchant/billing/gateways/flex_charge.rb Outdated Show resolved Hide resolved
@Heavyblade Heavyblade force-pushed the SER-1324_Addign_Authorize_functionality branch from db57ae3 to 47dc5a5 Compare July 5, 2024 15:33
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about the amount formatting.

lib/active_merchant/billing/gateways/flex_charge.rb Outdated Show resolved Hide resolved
Summary:
------------------------------
Changes FlexCharge to add support for the authorize and
capture operations and also a fix a bug on the `address_names`
method

[SER-1337](https://spreedly.atlassian.net/browse/SER-1337)
[SER-1324](https://spreedly.atlassian.net/browse/SER-1324)

Remote Test:
------------------------------
Finished in 72.283834 seconds.
19 tests, 54 assertions, 1 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
94.4444% passed

Unit Tests:
------------------------------
Finished in 43.11362 seconds.
5944 tests, 79908 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected
@Heavyblade Heavyblade force-pushed the SER-1324_Addign_Authorize_functionality branch from 47dc5a5 to bb2041b Compare July 8, 2024 15:27
@Heavyblade Heavyblade merged commit b72e61f into master Jul 8, 2024
5 checks passed
@Heavyblade Heavyblade deleted the SER-1324_Addign_Authorize_functionality branch July 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants