Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexCharge: quick fix on void call #5171

Merged
merged 1 commit into from
Jul 11, 2024
Merged

FlexCharge: quick fix on void call #5171

merged 1 commit into from
Jul 11, 2024

Conversation

Heavyblade
Copy link
Collaborator

Summary:

Changes FlexCharge to fix support for the void operation.

SER-1327

Tests

Remote Test:

Finished in 70.477035 seconds.
19 tests, 54 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Unit Tests:

Finished in 124.425603 seconds.
5959 tests, 79971 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:

798 files inspected, no offenses detected

@Heavyblade Heavyblade requested a review from naashton July 10, 2024 21:22
FlexCharge: Enabling void call

Summary:
------------------------------
Changes FlexCharge to fix support for the void operation and
also add the sense_key gsf

[SER-1327](https://spreedly.atlassian.net/browse/SER-1327)
[SER-1307](https://spreedly.atlassian.net/browse/SER-1307)

Remote Test:
------------------------------
Finished in 70.477035 seconds.
19 tests, 54 assertions, 0 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
100% passed

Unit Tests:
------------------------------
Finished in 124.425603 seconds.
5959 tests, 79971 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Heavyblade Heavyblade merged commit 8dc76a4 into master Jul 11, 2024
5 checks passed
@Heavyblade Heavyblade deleted the flex_charge_fix_void branch July 11, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants