-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paydollar payment gateway integration #764
Conversation
Adding integration helper and notification files.
Changed the methods per the response from Paydollar
Added files to test module, helper and notification
Fixed the test_notification_method
This file contains code and usage details for Paydollar module.
Saving with proper indentation
Added yard friendly comments and fixed indentation to have only spaces
Added yard friendly comments and fixed indentation to have only spaces
Added notification processing and yard friendly comment
Modified the test cases to handle the notifications processing
If the params['secureHash'] is nil then we don't want to try upcase
Added usage details for handling DataFeed via Notification
The nokogiri version 1.6.0 and above do NOT support ruby 1.8.7. However, the code in active_merchant is expected to work with 1.8.7. Hence, specifying the nokogiri version to be used.
Some old files refer to version 1.5.9 so using this exact version
@shintre I don't think the Paydollar specific README is really necessary; that said, I think there's some good content in there and I'd love it if you adapted it as a general doc about integrations, which are basically undocumented for ActiveMerchant. Also we won't take this with the nokogiri version locked; you should take a peek at the gemspec in HEAD and make sure this code works with Nokogiri specified as it is there. If you can verify that this will work with nokogiri spec'd as it is in HEAD, I'll work on getting this merged sans-README. Thanks! |
…hant/master/activemerchant.gemspec
…bout integration with active_merchant I liked Nathaniel Talbott's idea of having a generic document about integration with active_merchant.
Hi Nathaniel, I liked your idea on the generic document. Hence, I have deleted the Paydollar specific document and added a new document README.Integration.md that has generic description on how to integrate with active merchant. But, it uses Paydollar as an example for ease of understanding. As for the using the correct version of Nokogiri, I have made the changes per the "activemerchant.gemspec" file in the "Shopify/active_merchant" master branch. |
any progress on this PR? I'd like to get Paydollar working too. |
@ntalbott can you please let me know if there is still something you would like me to change? If not can we have it merged into the main tree? |
ActiveMerchant integrations have been extracted into https://github.com/Shopify/offsite_payments. This PR has been moved (via reference) to the new repo - please follow up on it there. |
Active Merchant - Paydollar payment gateway integration
NOTE - For details on Active Merchant read the README.md file.
This document provide details on the Paydollar branch and how to use the Paydollar module for client posts (i.e integration mode, where the credit card information page is put up by Paydollar)