-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for payu integration #811
Conversation
@melari can you take a look? Louis On Tue, Aug 20, 2013 at 11:33 AM, Sandeep Kumar notifications@github.comwrote:
|
@@ -11,6 +11,8 @@ module PayuIn | |||
|
|||
mattr_accessor :test_url | |||
mattr_accessor :production_url | |||
mattr_accessor :merchant_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These cannot be set this way, it doesn't work in a multi client environment. The credentials and secrets have to be passed in to the initialize method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. but since payu_in.rb is a module can I create a new method and pass variables to it.
def self.new(options)
@merchant_id = options[:merchant_id]
@secret_key = options[:secret_key]
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, needs to be passed into the notification, helper and return themselves. Ipay88 is one I fixed to do this correctly and would be a good example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important thing we don't want salt/secret_key to put in form as hidden field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any alternative for hidden field.
It doesn't look like all the changes required were made. |
ActiveMerchant integrations have been extracted into https://github.com/Shopify/offsite_payments. This PR has been moved (via reference) to the new repo - please follow up on it there. |
Note: Tested with test credentials.
Any questions mail me on sandeep.kumar@payu.in