Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for payu integration #811

Closed
wants to merge 3 commits into from
Closed

Conversation

buoyant
Copy link

@buoyant buoyant commented Aug 20, 2013

  1. Getting merchant_id and secret_key from app environment.
  2. Replaced productinfo with secret_key in generate_checksum method of helper class.
  3. Sending params to notification on response.

Note: Tested with test credentials.
Any questions mail me on sandeep.kumar@payu.in

@louiskearns
Copy link
Contributor

@melari can you take a look?


Louis

On Tue, Aug 20, 2013 at 11:33 AM, Sandeep Kumar notifications@github.comwrote:

  1. Getting merchant_id and secret_key from app environment.
  2. Replaced productinfo with secret_key in generate_checksum method of
    helper class.
  3. Sending params to notification on response.

Note: Tested with test credentials.

Any questions mail me on sandeep.kumar@payu.in

You can merge this Pull Request by running

git pull https://github.com/buoyant/active_merchant payu

Or view, comment on, or merge it at:

#811
Commit Summary

  • changes for payu integration

File Changes

Patch Links:

@@ -11,6 +11,8 @@ module PayuIn

mattr_accessor :test_url
mattr_accessor :production_url
mattr_accessor :merchant_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cannot be set this way, it doesn't work in a multi client environment. The credentials and secrets have to be passed in to the initialize method.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. but since payu_in.rb is a module can I create a new method and pass variables to it.

def self.new(options)
@merchant_id = options[:merchant_id]
@secret_key = options[:secret_key]
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, needs to be passed into the notification, helper and return themselves. Ipay88 is one I fixed to do this correctly and would be a good example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important thing we don't want salt/secret_key to put in form as hidden field.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any alternative for hidden field.

@ntalbott
Copy link
Contributor

ntalbott commented Oct 5, 2013

@jduff have you had a chance to review this since @buoyant's last change?

@jduff
Copy link
Contributor

jduff commented Oct 5, 2013

It doesn't look like all the changes required were made.

@ntalbott
Copy link
Contributor

ntalbott commented Jun 4, 2014

ActiveMerchant integrations have been extracted into https://github.com/Shopify/offsite_payments. This PR has been moved (via reference) to the new repo - please follow up on it there.

@ntalbott ntalbott closed this Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants