Added 'role' attribute to hidden tag fields of payment service form. #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a nil being passed to CGI.unescape. Closes #890.
…Response and passed the card_uri and account_uri back in authorization
There is already tokenization support for generating token after an authorization. This adds support for generating a token without an authorization. This method is useful because Mercury documentation explicitly disallows using a zero-auth for generating a token. Closes #898.
https://www.app55.com/ Currently supports #purchase and #authorize. Closes #748.
This makes it possible to choose the gateway token when running a transaction, not just when creating the SpreedlyCoreGateway.
Add support for multiple payment methods per customer. The `store' call now adds a payment method if a customer is specified (it used to clobber the default card instead). You can specify :set_default => true to set the newly created card as default. The `update' call will add the new card and set it as default. A new `update_customer' call has been added to update a customer's metadata. This commit also features a small refactoring in Stripe remote tests to easily swap the default currency used.
Specifying a card_id will now delete the card only, without deleting the customer. Closes #895.
I discovered that this was leaking internal host names, and could potentially leak other information depending on how a given distro implements uname. It also just seems less than prudent to shell out from within a gateway. I've also done a quick review of the code for any other uses of command execution (`` or %x) and found none. Closes #893.
Prior to this commit, the response code could show up within a number of different response param keys, depending on whether it was an authorize, a purchase, etc. Now, we have the 'response_code' key in the Response params allowing clients to get the code in the same way regardless of the operation. In addition, Active Merchant uses the response_code key for a number of other gateways. Closes #905.
Based on their site: https://www.elavon.com/country-selector/ Closes #909.
…s to integrations.
We've seen at least one case where the response body returned by Cecabank was unparsable. Previously this raised an exception; now we rescue the exception to include details in a proper ActiveMerchant::Response. Closes #1085.
Allowing customers to see the actual error code can help in two primary areas: * Communicating with the gateway's customer support about a given transaction. * Enabling customers to localize error messages if they so desire, especially for an international gateway like Wirecard. Now customers who care can access the error code in the ActiveMerchant::Response params, which is a gateway specific hash of response details. Closes #1086.
Fixing notification Moar work
More tests More tests and fixes Added tests
…y doesn't handle it without the dash
Litle doesn't like it if you specify an empty country for example. Closes #1101.
Specifically ip, description and gateway_specific_fields. Closes #1097.
|
ActiveMerchant integrations have been extracted into https://github.com/Shopify/offsite_payments. This PR has been moved (via reference) to the new repo - please follow up on it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change it's not possible to programmatically find these input elements by Javascript integration-independently because fields like "order" will have other actual names as set by particular service mappings.
With this patch "order" input for example for Paysbuy integration will be:
So I can query it with
without having to know particular input name.
More info on "role" html attribute http://www.w3.org/TR/role-attribute/