Merge branch 'main' into feat/test-polling

activepieces · Mar 29, 2023 · 3cd69ec · 3cd69ec
2 parents 0f2cb85 + dc56468
commit 3cd69ec
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/ee/product-embed/product-sdk/.eslintrc.json b/packages/ee/product-embed/product-sdk/.eslintrc.json
@@ -1,9 +1,12 @@
 {
-  "extends": ["../../../../packages/.eslintrc.json"],
+  "extends": ["../../../../.eslintrc.json"],
   "ignorePatterns": ["!**/*"],
   "overrides": [
     {
       "files": ["*.ts"],
+      "parserOptions": {
+        "project":["packages/ee/product-embed/product-sdk/tsconfig.*?.json"]
+      },
       "rules": {
         "rxjs/no-async-subscribe": "error",
         "rxjs/no-nested-subscribe": "error",

diff --git a/packages/ee/product-embed/product-sdk/src/app/app.component.ts b/packages/ee/product-embed/product-sdk/src/app/app.component.ts
@@ -97,6 +97,7 @@ export class AppComponent implements OnDestroy, AfterViewInit {
       Object.keys(SubscribeParamsValidationObject)
     );
     const subject = this.getEventSubject(eventName);
+    // eslint-disable-next-line rxjs-angular/prefer-async-pipe
     const subscription = subject.subscribe((val: any) => {
       callback(val);
     });
@@ -187,18 +188,21 @@ export class AppComponent implements OnDestroy, AfterViewInit {
 
 export interface SubscribeParams {
   eventName: SdkEvent;
+  // eslint-disable-next-line @typescript-eslint/ban-types
   callback: Function;
 }
 
 const SubscribeParamsValidationObject: SubscribeParams = {
   eventName: SdkEvent.CONNECTION,
-  callback: () => {},
+  callback: () => {
+    // Empty function
+  },
 };
 
 export interface InitParams {
   token: string;
   projectId: ProjectId;
-  host: String;
+  host: string;
   styles?: {
     primaryColor: string;
   };