Skip to content

Commit

Permalink
chore(lint): warn about semicolons
Browse files Browse the repository at this point in the history
  • Loading branch information
khaledmashaly committed Mar 29, 2023
1 parent cc95455 commit ce8a228
Show file tree
Hide file tree
Showing 112 changed files with 2,307 additions and 2,306 deletions.
3 changes: 2 additions & 1 deletion packages/backend/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"@typescript-eslint/brace-style": ["error", "stroustrup"],
"@typescript-eslint/comma-dangle": ["error", "always-multiline"],
"@typescript-eslint/indent": ["error", 4],
"@typescript-eslint/quotes": ["error", "single"]
"@typescript-eslint/quotes": ["error", "single"],
"@typescript-eslint/semi": ["warn", "never"]
}
},
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { FastifyInstance, FastifyRequest } from 'fastify';
import { StatusCodes } from 'http-status-codes';
import { AppConnectionId, ListAppConnectionRequest, UpsertConnectionRequest } from '@activepieces/shared';
import { ActivepiecesError, ErrorCode } from '@activepieces/shared';
import { appConnectionService } from './app-connection.service';
import { FastifyInstance, FastifyRequest } from 'fastify'
import { StatusCodes } from 'http-status-codes'
import { AppConnectionId, ListAppConnectionRequest, UpsertConnectionRequest } from '@activepieces/shared'
import { ActivepiecesError, ErrorCode } from '@activepieces/shared'
import { appConnectionService } from './app-connection.service'

const DEFAULT_PAGE_SIZE = 10;
const DEFAULT_PAGE_SIZE = 10
export const appConnectionController = async (fastify: FastifyInstance) => {

fastify.post(
Expand All @@ -19,13 +19,13 @@ export const appConnectionController = async (fastify: FastifyInstance) => {
Body: UpsertConnectionRequest;
}>,
) => {
const connection = await appConnectionService.upsert({ projectId: request.principal.projectId, request: request.body });
const connection = await appConnectionService.upsert({ projectId: request.principal.projectId, request: request.body })
// Remove sensitive data from response
delete connection.value['client_secret'];
delete connection.value['refresh_token'];
return connection;
delete connection.value['client_secret']
delete connection.value['refresh_token']
return connection
},
);
)


fastify.get(
Expand All @@ -37,19 +37,19 @@ export const appConnectionController = async (fastify: FastifyInstance) => {
};
}>,
) => {
const appCredential = await appConnectionService.getOne({ projectId: request.principal.projectId, name: request.params.connectionName });
const appCredential = await appConnectionService.getOne({ projectId: request.principal.projectId, name: request.params.connectionName })
if (appCredential === null) {
throw new ActivepiecesError({
code: ErrorCode.APP_CONNECTION_NOT_FOUND,
params: { id: request.params.connectionName },
});
})
}
// Remove sensitive data from response
delete appCredential.value['client_secret'];
delete appCredential.value['refresh_token'];
return appCredential;
delete appCredential.value['client_secret']
delete appCredential.value['refresh_token']
return appCredential
},
);
)

fastify.get(
'/',
Expand All @@ -63,12 +63,12 @@ export const appConnectionController = async (fastify: FastifyInstance) => {
Querystring: ListAppConnectionRequest;
}>,
) => {
const query = request.query;
const query = request.query
return await appConnectionService.list(request.principal.projectId,
query.appName,
query.cursor ?? null, query.limit ?? DEFAULT_PAGE_SIZE);
query.cursor ?? null, query.limit ?? DEFAULT_PAGE_SIZE)
},
);
)

fastify.delete(
'/:connectionId',
Expand All @@ -80,8 +80,8 @@ export const appConnectionController = async (fastify: FastifyInstance) => {
}>,
_reply,
) => {
await appConnectionService.delete({ id: request.params.connectionId, projectId: request.principal.projectId });
_reply.status(StatusCodes.OK).send();
await appConnectionService.delete({ id: request.params.connectionId, projectId: request.principal.projectId })
_reply.status(StatusCodes.OK).send()
},
);
};
)
}
12 changes: 6 additions & 6 deletions packages/backend/src/app/app-connection/app-connection.entity.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { AppConnection, Project } from '@activepieces/shared';
import { EntitySchema } from 'typeorm';
import { ApIdSchema, BaseColumnSchemaPart } from '../helper/base-entity';
import { EncryptedObject } from '../helper/encryption';
import { AppConnection, Project } from '@activepieces/shared'
import { EntitySchema } from 'typeorm'
import { ApIdSchema, BaseColumnSchemaPart } from '../helper/base-entity'
import { EncryptedObject } from '../helper/encryption'

export type AppConnectionSchema = AppConnection & { project: Project , value: EncryptedObject};
export type AppConnectionSchema = AppConnection & { project: Project , value: EncryptedObject}

export const AppConnectionEntity = new EntitySchema<AppConnectionSchema>({
name: 'app_connection',
Expand Down Expand Up @@ -39,4 +39,4 @@ export const AppConnectionEntity = new EntitySchema<AppConnectionSchema>({
},
},
},
});
})
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { FastifyInstance } from 'fastify';
import { appConnectionController } from './app-connection.controller';
import { FastifyInstance } from 'fastify'
import { appConnectionController } from './app-connection.controller'

export const appConnectionModule = async (app: FastifyInstance) => {
app.register(appConnectionController, { prefix: '/v1/app-connections' });
};
app.register(appConnectionController, { prefix: '/v1/app-connections' })
}
Loading

0 comments on commit ce8a228

Please sign in to comment.