chore: enforce limit on storage key to be maximum 128 #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuaboud
force-pushed
the
enforce/store-key-limiit
branch
2 times, most recently
from
8117785
to
82877a1
Compare
There was a problem hiding this comment.
Good! Here are some points for your reference:
- I think it would be better to add a constant in
shared/store-entrynamed sth likeSTORE_ENTRY_KEY_LIMITinstead of hard-coding128everywhere - If SQLite doesn't enforce key length, then there's no need to drop keys with length larger than 128, right?
abuaboud
force-pushed
the
enforce/store-key-limiit
branch
from
82877a1
to
ff0519a
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1aa5df3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
abuaboud
force-pushed
the
enforce/store-key-limiit
branch
2 times, most recently
from
222ba38
to
cf78bb7
Compare
abuaboud
force-pushed
the
enforce/store-key-limiit
branch
from
cf78bb7
to
1aa5df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)