Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): EXTERNAL_CUSTOMER role and SHOW_ACTIVITY_LOG flag #3999

Merged
merged 5 commits into from
Feb 25, 2024

Conversation

khaledmashaly
Copy link
Contributor

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

nx-cloud bot commented Feb 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d9673b8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@khaledmashaly khaledmashaly changed the title feat: external customer role 3983 feat(api): EXTERNAL_CUSTOMER role and SHOW_ACTIVITY_LOG flag Feb 25, 2024
@khaledmashaly khaledmashaly marked this pull request as ready for review February 25, 2024 13:06
@khaledmashaly khaledmashaly self-assigned this Feb 25, 2024

export const RolesDisplayNames: { [k: string]: string } = {
[ProjectMemberRole.ADMIN]: $localize`Admin`,
[ProjectMemberRole.EDITOR]: $localize`Editor`,
[ProjectMemberRole.VIEWER]: $localize`Viewer`,
[ProjectMemberRole.EXTERNAL_CUSTOMER]: $localize`External Customer`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add issue to hide it when feature is not enabled

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it in front end.

@khaledmashaly khaledmashaly merged commit cff157a into main Feb 25, 2024
11 of 12 checks passed
@khaledmashaly khaledmashaly deleted the feat/activiy-viewer-role-3983 branch February 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer Dashboard: Specific role for users to redirect only to the customer dashboard
4 participants