Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quickbooks): create customer, update customer and find customer actions #4089

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

kishanprmr
Copy link
Collaborator

@kishanprmr kishanprmr commented Mar 5, 2024

What does this PR do?

Fixes #4031

@kishanprmr kishanprmr marked this pull request as draft March 5, 2024 09:19
Copy link

nx-cloud bot commented Mar 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0756bd6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@kishanprmr kishanprmr changed the title feat(quickbooks): customer and invoice actions feat(quickbooks): create customer, update customer and find customer actions Mar 15, 2024
@kishanprmr kishanprmr marked this pull request as ready for review March 15, 2024 06:08
@ikus060
Copy link

ikus060 commented Apr 3, 2024

@kishanprmr Thanks for you contribution. I was looking for this piece for my integration. I need to create an estimate and a customer. I can't wait to test it.

I see you created the code for Customer. How hard is it to add other entry point like estimate ?

@abuaboud abuaboud added the blocked dependent on another issue label Apr 19, 2024
@ikus060
Copy link

ikus060 commented Apr 23, 2024

My I suggest a different approach to this implementation that would unblock this piece.

I would recommend splitting the creation of invoice and the creation of item/lines in the invoice in two different actions. That would allow creation of an empty invoice, followed by the creation of one or multiple invoice lines based on different condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked dependent on another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuickBooks
3 participants