Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete project from the admin console #4146

Merged
merged 15 commits into from Mar 18, 2024
Merged

feat: delete project from the admin console #4146

merged 15 commits into from Mar 18, 2024

Conversation

khaledmashaly
Copy link
Contributor

@khaledmashaly khaledmashaly commented Mar 11, 2024 •
edited

What does this PR do?

Fixes #4101

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 11, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2aa013d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@khaledmashaly khaledmashaly self-assigned this Mar 18, 2024
@khaledmashaly khaledmashaly marked this pull request as ready for review March 18, 2024 02:44
abuaboud
abuaboud previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@abuaboud abuaboud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job <3

@abuaboud abuaboud added the 🌟 feature new major feature label Mar 18, 2024
@abuaboud abuaboud changed the title feat(api): delete project feat: ability to delete project from the admin console Mar 18, 2024
@khaledmashaly khaledmashaly changed the title feat: ability to delete project from the admin console feat: delete project from the admin console Mar 18, 2024
@abuaboud abuaboud merged commit 36585f9 into main Mar 18, 2024
16 of 17 checks passed
@khaledmashaly khaledmashaly deleted the feat/delete-project-4101 branch April 1, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuaboud abuaboud abuaboud approved these changes

Assignees

@khaledmashaly khaledmashaly

Labels
auto-deploy 🌟 feature new major feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduled hard delete Project
3 participants
@khaledmashaly @CLAassistant @abuaboud