Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase sidenav caption width #4279

Merged
merged 2 commits into from Apr 1, 2024

Conversation

takaram
Copy link
Contributor

@takaram takaram commented Mar 26, 2024

What does this PR do?

When you switch the language to Japanese, you will notice that the word "コネクション" (connection) in the sidenav is wrapped into four lines.
While in English a single word cannot be wrapped by default, in some languages like Japanese this is not the case.

This PR increases the width of the captions in the sidenav to minimize the word wrapping.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

nx-cloud bot commented Mar 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 037893b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@abuaboud
Copy link
Contributor

Thank you @takaram , @AbdulTheActivePiecer can you please take look

@AbdulTheActivePiecer
Copy link
Collaborator

Well done, I removed a little bit of extra padding as well to it your word fully on one line, cheers 😄 @takaram

@AbdulTheActivePiecer AbdulTheActivePiecer merged commit 6b0060c into activepieces:main Apr 1, 2024
8 checks passed
@takaram takaram deleted the sidenav-label branch April 2, 2024 12:51
@abuaboud abuaboud added the ⭐ enhancement New feature or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants