Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change pulumi project name in package.json #4463

Merged
merged 1 commit into from Apr 14, 2024

Conversation

islamaf
Copy link
Collaborator

@islamaf islamaf commented Apr 14, 2024

What does this PR do?

This PR resolves the issue where the activepieces project was incorrectly defined in multiple locations within our repository. Specifically, in the root path and under deploy/pulumi. This caused build failures due to non-unique naming conflicts detected by our build tools.

Changes Made

  • Changed the project name in deploy/pulumi/package.json to have a unique identifier.

Log Summary

  • API & GUI:
[API]
[API]  NX   The following projects are defined in multiple locations:
[API]
[API] - activepieces:
[API]   - .
[API]   - deploy/pulumi
[API]
[API] To fix this, set a unique name for each project in a project.json inside the project's root. If the project does not currently have a project.json, you can create one that contains only a name.
[API]
[API] Because of the error the Nx daemon process has exited. The next Nx command is going to restart the daemon process.
[API] If the error persists, please run "nx reset".
[API]
[GUI]
[GUI]  NX   The following projects are defined in multiple locations:
[GUI]
[GUI] - activepieces:
[GUI]   - .
[GUI]   - deploy/pulumi
[GUI]
[GUI] To fix this, set a unique name for each project in a project.json inside the project's root. If the project does not currently have a project.json, you can create one that contains only a name.
[GUI]
[GUI] Because of the error the Nx daemon process has exited. The next Nx command is going to restart the daemon process.
[GUI] If the error persists, please run "nx reset".
[GUI]
[GUI] Because of the error the Nx daemon process has exited. The next Nx command is going to restart the daemon process.
[GUI] If the error persists, please run "nx reset".
[GUI]
  • PCS:
[PCS]  NX   The following projects are defined in multiple locations:
[PCS]
[PCS] - activepieces:
[PCS]   - .
[PCS]   - deploy/pulumi
[PCS]
[PCS] To fix this, set a unique name for each project in a project.json inside the project's root. If the project does not currently have a project.json, you can create one that contains only a name.
[PCS]
[PCS] Because of the error the Nx daemon process has exited. The next Nx command is going to restart the daemon process.
[PCS] If the error persists, please run "nx reset".

@islamaf islamaf requested a review from abuaboud April 14, 2024 10:08
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

nx-cloud bot commented Apr 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5fb7e12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@abuaboud
Copy link
Contributor

@allcontributors please add @islamaf for bug

@abuaboud abuaboud merged commit 9254ac6 into main Apr 14, 2024
12 checks passed
Copy link
Contributor

@abuaboud

I've put up a pull request to add @islamaf! 🎉

@abuaboud abuaboud added 💻 dx developer experience 🧹 clean up Things are no longer needed labels Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 clean up Things are no longer needed 💻 dx developer experience
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants