fix: delay step were failing after loop #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a657606. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
| @@ -107,7 +110,7 @@ export const newOrUpdatedRowTrigger = createTrigger({ | |||
| ); | |||
|
|
|||
| const range = | |||
| triggerColumn === 'all_columns' | |||
| triggerColumn === ALL_COLUMNS | |||
There was a problem hiding this comment.
What happens when a column is called "all_columns"?
An array-based mechanism might be more appropriate here, then we'd also get multiple trigger columns for free.
| @@ -67,7 +67,8 @@ export class FlowExecutorContext { | |||
| return undefined | |||
| } | |||
| assertEqual(stepOutput.type, ActionType.LOOP_ON_ITEMS, 'stepOutput.type', 'LOOP_ON_ITEMS') | |||
| return stepOutput as LoopStepOutput | |||
| // The new LoopStepOutput is needed as casting to LoopStepOutput will just cast the data but the class methods will not be available | |||
There was a problem hiding this comment.
I'm looking at this on a phone so pardon me if this is a dumb question, but why is it safe to cast to LoopStepOutput at all?
| @@ -44,14 +47,14 @@ export const newOrUpdatedRowTrigger = createTrigger({ | |||
| trigger_column: Property.Dropdown({ | |||
| displayName: 'Trigger Column', | |||
| description: `Trigger on changes to cells in this column only.Select **All Columns** if you want the flow to trigger on changes to any cell within the row.`, | |||
There was a problem hiding this comment.
Shouldn't these be translation keys?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)