Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture price #68

Merged
merged 9 commits into from
Nov 29, 2018
Merged

Capture price #68

merged 9 commits into from
Nov 29, 2018

Conversation

chasingSublimity
Copy link
Contributor

@chasingSublimity chasingSublimity commented Oct 31, 2018

This supports capturing the price response variable for the JSON, XML, SOAP, and Form POST integrations.

Here's the ticket for (a little) more context.

@chasingSublimity
Copy link
Contributor Author

chasingSublimity commented Nov 6, 2018

@alexkwolfe Updated. Can you take a look at response.coffee and verify that this is what you wanted? (Still need to adjust the soap file) done.

Copy link
Contributor

@alexkwolfe alexkwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need tests for JSON, HTML, and text response parsing?

@chasingSublimity
Copy link
Contributor Author

Are you asking if there are tests we need to add? JSON, HTML, and text price parsing tests are all present.

JSON: L#333 of response-spec.coffee
HTML: L#665 of response-spec.coffee
Text: L#465 of response-spec.coffee

Or maybe you're asking if those tests are necessary?

@alexkwolfe
Copy link
Contributor

Are you asking if there are tests we need to add? JSON, HTML, and text price parsing tests are all present.

Shit. Sorry man. Github was hiding the large diff and I ignored it thinking it was a package-lock.json or something.

@chasingSublimity
Copy link
Contributor Author

No worries. Did you mean to approve this, as well? Currently, it's not on staging with the other pricing changes :)

Copy link
Contributor

@alexkwolfe alexkwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chasingSublimity chasingSublimity merged commit 9b5327d into master Nov 29, 2018
@chasingSublimity chasingSublimity deleted the capture-price branch November 29, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants