-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture price #68
Capture price #68
Conversation
@alexkwolfe Updated. Can you take a look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need tests for JSON, HTML, and text response parsing?
Are you asking if there are tests we need to add? JSON, HTML, and text price parsing tests are all present. JSON: L#333 of Or maybe you're asking if those tests are necessary? |
Shit. Sorry man. Github was hiding the large diff and I ignored it thinking it was a package-lock.json or something. |
No worries. Did you mean to approve this, as well? Currently, it's not on staging with the other pricing changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This supports capturing the
price
response variable for the JSON, XML, SOAP, and Form POST integrations.Here's the ticket for (a little) more context.