Guard against undefined with bogus searchpath #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasingSublimity
changed the title
cgrayson
approved these changes
Nov 12, 2018
chasingSublimity
force-pushed
the
guard-against-undefined-searchpath
branch
from
aea4aa3
to
16612f4
Compare
chasingSublimity
force-pushed
the
guard-against-undefined-searchpath
branch
from
568fce1
to
0b2a874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given a wonky
search_path, the integration bonks: https://next.leadconduit.com/events/5be4c2c9d65e852e8b5fb863/5be4c2c9d65e852e8b5fb864The test for this feels lame. I tried using
assert.doesNotThrowbut couldn't figure out how it works. Any suggestions?Note to self: Add a changelog note