Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding lambda deploy actions #78

Merged
merged 8 commits into from
Feb 23, 2021

Conversation

chasingSublimity
Copy link
Contributor

@chasingSublimity chasingSublimity commented Feb 22, 2021

Description of the change

This is the first commit needed to move rip deployment to GH Actions. To my great annoyance, workflow manifests need to be in the default branch for the GH UI to recognize them. In other words, i cant debug or verify that the actions are running as expected until the file is first in master. -_-

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Documentation

Related tickets

Link to Clubhouse Ticket Goes Here

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • This branch has been rebased off master to be current.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.

Tracking

  • Issue from Clubhouse has a link to this pull request.
  • This PR has a link to the issue in Clubhouse.

QA

  • This branch has been deployed to staging and tested.

Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

.github/workflows/development.yml Show resolved Hide resolved
@chasingSublimity chasingSublimity merged commit dd91e67 into master Feb 23, 2021
@chasingSublimity chasingSublimity deleted the add-lambda-deploy-action branch February 23, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants