Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment for each workflow #85

Conversation

Kshitiz-devops
Copy link
Contributor

Description of the change

Add environmentto workflow so that respective secrets can be utilized

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.clubhouse.io/active-prospect/story/29711/change-work-flow-and-add-secrets-per-environment

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Clubhouse has a link to this pull request.
  • This PR has a link to the issue in Clubhouse.

QA

  • This branch has been deployed to staging and tested.

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #29711: Change work flow and add secrets per environment.

@Kshitiz-devops Kshitiz-devops merged commit b1aa22d into master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants