Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inbound feedback integration #3

Merged
merged 2 commits into from
Jul 20, 2016
Merged

Add inbound feedback integration #3

merged 2 commits into from
Jul 20, 2016

Conversation

alexkwolfe
Copy link
Contributor

@alexkwolfe alexkwolfe commented Jul 20, 2016

This integration is for use in the forthcoming "feedback" feature. Its purpose is to receive feedback from a recipient about a lead. Two types of feedback are supported by the handler: return and conversion. But this integration will pass through all feedback types.

@@ -0,0 +1,178 @@
_ = require('lodash')
url = require('url')
querystring = require('querystring')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where this is needed.

vars =
lead: { id: '123' }
outcome: 'failure'
reason: 'bad!'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

26809-5ltv4n

@cgrayson cgrayson assigned alexkwolfe and unassigned cgrayson Jul 20, 2016
@cgrayson
Copy link
Contributor

L 👌 TM, as I think I understand the mirror-world of inbounds on the outbound side… which I think this is? (Right?). Will this be kept separate from real, regular inbounds, like "verbose", in the UI?

@alexkwolfe
Copy link
Contributor Author

alexkwolfe commented Jul 20, 2016

inbounds on the outbound side… which I think this is? (Right?)

Yep!

Will this be kept separate from real, regular inbounds, like "verbose", in the UI?

Yes. That will happen because of the module naming convention. Integrations with a *.inbound.feedback module ID will appear only as an inbound on the recipient side...

@alexkwolfe alexkwolfe merged commit 5c29394 into master Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants