Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test and getValues method to url values #22

Closed
wants to merge 1 commit into from

Conversation

wellhausen
Copy link

@zalary, this potentially solves issue #14

  • update the test body in add_item_spec.coffee
  • update method calls with parenthesis for consistency in query_item.coffee
  • utilize escape method to URL encode in helper.coffee

@wellhausen
Copy link
Author

Ok, noted. Looking into this.

@wellhausen
Copy link
Author

  • Using encodeURIComponent() rather than escape() will encode everything with the exception of:
    ~!*()'

@@ -16,7 +16,7 @@ describe 'Add List Item', ->
assert.equal 'POST', request.method

it 'should have the correct body', ->
assert.equal '{"values":"boilermakers@example.com|taylor@activeprospect.com"}', request.body
assert.equal '{"values":"boilermakers@example.com%2C%20taylor@activeprospect.com"}', request.body
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to URL encode JSON.

@wellhausen
Copy link
Author

@alexkwolfe - so this change is not needed at all?

@alexkwolfe
Copy link
Contributor

It's not clear to me what problem issue #14 is reporting...

@wellhausen
Copy link
Author

Ok, I will talk with Zalary to get more details.

@cgrayson
Copy link
Contributor

cgrayson commented Jun 2, 2015

Noticed this old PR still hanging out, @ros3bud (or @zalary) - do you know if this is still a pending thing?

@wellhausen
Copy link
Author

@cgrayson - it is still pending. Here is what needs to happen:

  1. Send test leads to a flow which uses SuppressionList in LC which contains emails with odd characters. For example: Extraneous Content-Type header on GET request #1&2%3.
  2. Once it's determined how the odd characters are handled, update the integration accordingly.

@wellhausen
Copy link
Author

Going to close out this PR and add a new issue as this has taken a new shape.

@wellhausen wellhausen closed this Jun 3, 2015
@wellhausen wellhausen deleted the urlendcode_values branch June 3, 2015 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants