New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update test and getValues method to url values #22
Conversation
Ok, noted. Looking into this. |
|
@@ -16,7 +16,7 @@ describe 'Add List Item', -> | |||
assert.equal 'POST', request.method | |||
|
|||
it 'should have the correct body', -> | |||
assert.equal '{"values":"boilermakers@example.com|taylor@activeprospect.com"}', request.body | |||
assert.equal '{"values":"boilermakers@example.com%2C%20taylor@activeprospect.com"}', request.body |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary to URL encode JSON.
@alexkwolfe - so this change is not needed at all? |
It's not clear to me what problem issue #14 is reporting... |
Ok, I will talk with Zalary to get more details. |
Noticed this old PR still hanging out, @ros3bud (or @zalary) - do you know if this is still a pending thing? |
@cgrayson - it is still pending. Here is what needs to happen:
|
Going to close out this PR and add a new issue as this has taken a new shape. |
@zalary, this potentially solves issue #14