add toll-free area codes to description #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasingSublimity
requested review from
alexkwolfe
and removed request for
jgrayson676
alexkwolfe
approved these changes
Oct 25, 2017
| @@ -151,7 +151,7 @@ components = [ | |||
| { name: 'extension', type: 'string', description: 'Extension' } | |||
| { name: 'country_code', type: 'string', description: 'Country code' } | |||
| { name: 'type', type: 'string', description: 'Number type: home, work, mobile' } | |||
| { name: 'is_tollfree', type: 'boolean', description: 'Whether the number is toll-free' } | |||
There was a problem hiding this comment.
You could also extract the toll free area codes from the lookup object, so that if a new code is used it automatically gets picked up in the description...
description: "Whether the number is toll-free (#{Object.keys(tollFreeAreaCodes).join(', ')})"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #101