Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blakesager/ch5051/convert lc types to es6 #118

Merged
merged 14 commits into from
Feb 18, 2020

Conversation

chasingSublimity
Copy link
Contributor

@chasingSublimity chasingSublimity commented Feb 11, 2020

Two things of note:

  1. For the operators tests, the list of supportedOperators is now imported from the rules package.

  2. There were was a UK phone test that had a bunch of commented-out assert statements. Because nothing was actually tested, the test appeared to pass. The test now skips, so we are at least aware of it. I can swing back around and see if we want to refactor that test later, if necessary.

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c5b8945). Click here to learn what that means.
The diff coverage is 98.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage          ?   98.71%           
=========================================
  Files             ?       58           
  Lines             ?     2094           
  Branches          ?        0           
=========================================
  Hits              ?     2067           
  Misses            ?       27           
  Partials          ?        0
Impacted Files Coverage Δ
lib/aggregations/range.js 100% <100%> (ø)
lib/types/city.js 100% <100%> (ø)
spec/number-spec.js 100% <100%> (ø)
spec/range-spec.js 100% <100%> (ø)
spec/email-spec.js 100% <100%> (ø)
lib/types/email.js 100% <100%> (ø)
lib/normalize.js 100% <100%> (ø)
lib/types/index.js 100% <100%> (ø)
lib/aggregations/street.js 100% <100%> (ø)
lib/types/number.js 100% <100%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b8945...19c6f44. Read the comment docs.

spec/operators-spec.js Outdated Show resolved Hide resolved
@activeprospect activeprospect deleted a comment from codingmatty Feb 12, 2020
@chasingSublimity
Copy link
Contributor Author

the codingmatty thing is because of the codecov token in travis i think.

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c5b8945). Click here to learn what that means.
The diff coverage is 97.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage          ?   97.04%           
=========================================
  Files             ?       34           
  Lines             ?      576           
  Branches          ?        0           
=========================================
  Hits              ?      559           
  Misses            ?       17           
  Partials          ?        0
Impacted Files Coverage Δ
lib/aggregations/range.js 100% <100%> (ø)
lib/types/city.js 100% <100%> (ø)
lib/types/email.js 100% <100%> (ø)
lib/normalize.js 100% <100%> (ø)
lib/aggregations/street.js 100% <100%> (ø)
lib/types/number.js 100% <100%> (ø)
lib/aggregations/state.js 100% <100%> (ø)
lib/types/phone.js 100% <100%> (ø)
lib/aggregate.js 100% <100%> (ø)
lib/types/last_name.js 100% <100%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b8945...954dd60. Read the comment docs.

Copy link
Contributor

@alexkwolfe alexkwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chasingSublimity
Copy link
Contributor Author

bump @mikebetts

Copy link
Contributor

@mikebetts mikebetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just those minor things...

test/phone.test.js Outdated Show resolved Hide resolved
.npmignore Outdated Show resolved Hide resolved
Copy link
Contributor

@mikebetts mikebetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that .travis.yml isn't in the .npmignore, otherwise LGTM.

@chasingSublimity chasingSublimity force-pushed the blakesager/ch5051/convert-lc-types-to-es6 branch from c618289 to 954dd60 Compare February 18, 2020 14:22
@activeprospect activeprospect deleted a comment from codingmatty Feb 18, 2020
@activeprospect activeprospect deleted a comment from codingmatty Feb 18, 2020
@chasingSublimity chasingSublimity merged commit 810a252 into master Feb 18, 2020
@chasingSublimity chasingSublimity deleted the blakesager/ch5051/convert-lc-types-to-es6 branch February 18, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants