-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blakesager/ch5051/convert lc types to es6 #118
Blakesager/ch5051/convert lc types to es6 #118
Conversation
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage ? 98.71%
=========================================
Files ? 58
Lines ? 2094
Branches ? 0
=========================================
Hits ? 2067
Misses ? 27
Partials ? 0
Continue to review full report at Codecov.
|
the |
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage ? 97.04%
=========================================
Files ? 34
Lines ? 576
Branches ? 0
=========================================
Hits ? 559
Misses ? 17
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bump @mikebetts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just those minor things...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that .travis.yml isn't in the .npmignore, otherwise LGTM.
c618289
to
954dd60
Compare
Two things of note:
For the
operators
tests, the list ofsupportedOperators
is now imported from the rules package.There were was a UK phone test that had a bunch of commented-out
assert
statements. Because nothing was actually tested, the test appeared to pass. The test now skips, so we are at least aware of it. I can swing back around and see if we want to refactor that test later, if necessary.