Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rules to devDependencies #119

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

chasingSublimity
Copy link
Contributor

-rules is only used in the test suite. Moving this dep into devDependencies allows public packages to use the -types module without having an NPM token

@codecov-io
Copy link

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   97.04%   97.04%           
=======================================
  Files          34       34           
  Lines         576      576           
=======================================
  Hits          559      559           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b8842...610db60. Read the comment docs.

Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chasingSublimity chasingSublimity merged commit 63410ca into master Feb 19, 2020
@chasingSublimity chasingSublimity deleted the move-rules-to-dev-dependencies branch February 19, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants