update to use latest chrono-node/handle excessive fractional seconds #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes the
time
type's handling of timestamps with more than 4 decimal places of fractional seconds.This is accomplished by updating to use the latest public version of
chrono-node
, which is used for the fundamental time parsing.@alexkwolfe - Let me know if you have concerns about this change - it replaces your previously branched version at
git+https://github.com/alexkwolfe/chrono.git#milliseconds
. It looks like your change was to add support for parsing milliseconds (what I'm calling "fractional seconds" here). Now the mainline public version ofchrono-node
does that itself, plus whatever other fixes (including vulnerabilities) since your fork. All the time tests still pass, of course.Type of change
Related tickets
https://app.shortcut.com/active-prospect/story/58714/lc-time-type-fails-on-too-many-decimal-places-of-fractional-seconds
Checklists
Development and Testing
Code Review
Tracking
QA