Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use latest chrono-node/handle excessive fractional seconds #161

Merged

Conversation

cgrayson
Copy link
Contributor

Description of the change

Fixes the time type's handling of timestamps with more than 4 decimal places of fractional seconds.

This is accomplished by updating to use the latest public version of chrono-node, which is used for the fundamental time parsing.

@alexkwolfe - Let me know if you have concerns about this change - it replaces your previously branched version at git+https://github.com/alexkwolfe/chrono.git#milliseconds. It looks like your change was to add support for parsing milliseconds (what I'm calling "fractional seconds" here). Now the mainline public version of chrono-node does that itself, plus whatever other fixes (including vulnerabilities) since your fork. All the time tests still pass, of course.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.shortcut.com/active-prospect/story/58714/lc-time-type-fails-on-too-many-decimal-places-of-fractional-seconds

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

@shortcut-integration
Copy link

@cgrayson cgrayson requested a review from alexkwolfe June 20, 2023 16:20
@cgrayson cgrayson temporarily deployed to test June 20, 2023 18:31 — with GitHub Actions Inactive
@cgrayson cgrayson temporarily deployed to test June 20, 2023 18:31 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (14a3d0a) 97.43% compared to head (03296e4) 97.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          37       37           
  Lines         701      701           
=======================================
  Hits          683      683           
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@johnrb2 johnrb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

Copy link
Contributor

@alexkwolfe alexkwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L⏱️TM

@cgrayson cgrayson merged commit da8ce6d into master Jun 21, 2023
4 checks passed
@cgrayson cgrayson deleted the sc-58714/lc-time-type-fails-on-too-many-decimal-places branch June 21, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants