Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 60407/add ipv6 support to the ip address data type #166

Merged

Conversation

johnrb2
Copy link
Contributor

@johnrb2 johnrb2 commented Sep 6, 2023

Description of the change

Create IP type, Validate IP addresses using Node's built-in URL API, fix minor issues with url type for clarity.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.shortcut.com/active-prospect/story/60407/add-ipv6-support-to-the-ip-address-data-type

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #60407: Add IPv6 support to the IP address data type.

Copy link
Contributor

@jgrayson676 jgrayson676 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple minor comments about the components this looks good.

Before this gets deployed we should check if there are any integrations requesting ip typed fields. There shouldn't be, as it wouldn't have done anything before this, but the standard ip_address field already using that type makes me wonder if that's the case elsewhere.

lib/types/ip.js Outdated Show resolved Hide resolved
lib/types/ip.js Outdated Show resolved Hide resolved
ericyd
ericyd previously approved these changes Sep 7, 2023
Copy link
Member

@ericyd ericyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like both of Chris's Jonathan's feedback but otherwise this looks great! Excellent specs 👏🏻 👏🏻 👏🏻

test/ip.test.js Show resolved Hide resolved
test/ip.test.js Show resolved Hide resolved
Copy link
Member

@ericyd ericyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@johnrb2 johnrb2 force-pushed the sc-60407/add-ipv6-support-to-the-ip-address-data-type branch from b84c5b1 to 37670ae Compare September 8, 2023 14:19
@johnrb2 johnrb2 temporarily deployed to test September 8, 2023 14:19 — with GitHub Actions Inactive
@johnrb2 johnrb2 temporarily deployed to test September 8, 2023 14:19 — with GitHub Actions Inactive
@johnrb2 johnrb2 temporarily deployed to test September 8, 2023 14:19 — with GitHub Actions Inactive
@johnrb2 johnrb2 merged commit 37ec10e into master Sep 8, 2023
5 checks passed
@johnrb2 johnrb2 deleted the sc-60407/add-ipv6-support-to-the-ip-address-data-type branch September 8, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants