-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sc 60407/add ipv6 support to the ip address data type #166
Sc 60407/add ipv6 support to the ip address data type #166
Conversation
This pull request has been linked to Shortcut Story #60407: Add IPv6 support to the IP address data type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a couple minor comments about the components this looks good.
Before this gets deployed we should check if there are any integrations requesting ip
typed fields. There shouldn't be, as it wouldn't have done anything before this, but the standard ip_address
field already using that type makes me wonder if that's the case elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like both of Chris's Jonathan's feedback but otherwise this looks great! Excellent specs 👏🏻 👏🏻 👏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b84c5b1
to
37670ae
Compare
Description of the change
Type of change
Related tickets
Checklists
Development and Testing
Code Review
Tracking
QA