sc-64578/fix-invalid-url-bug

[johnrb2]

Description of the change

add try/catch for invalid domain; run lint:fix

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Configuration change
• Technical Debt
• Documentation

Related tickets

https://app.shortcut.com/active-prospect/story/64578/fix-invalid-url-bug

Checklists

Development and Testing

• Lint rules pass locally.
• The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
• All tests related to the changed code pass in development, or tests are not applicable.

Code Review

• This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
• At least two engineers have been added as "Reviewers" on the pull request.
• Changes have been reviewed by at least two other engineers who did not write the code.
• This branch has been rebased off master to be current.

Tracking

• Issue from Shortcut/Jira has a link to this pull request.
• This PR has a link to the issue in Shortcut.

QA

• This branch has been deployed to staging and tested.

[shortcut-integration]

This pull request has been linked to Shortcut Story #64578: fix invalid url bug.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cd6a91) 97.56% compared to head (d436eaf) 97.54%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   97.56%   97.54%   -0.03%     
==========================================
  Files          38       38              
  Lines         739      732       -7     
==========================================
- Hits          721      714       -7     
  Misses         18       18              

Files	Coverage Δ
lib/types/email.js	100.00% <100.00%> (ø)
lib/types/trustedform_url.js	96.92% <100.00%> (-0.42%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johnrb2]

v16 test will go away once this branch is merged to master

[cgrayson]

I mentioned in the story I opened for this that we might want to address this in the handleFreemailValidation code, which we have our own forked copy of (for some reason). But I don't see any other significant usage of that package, so I think this fine 👍