Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/93 #94

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Fix/93 #94

merged 1 commit into from
Jun 23, 2017

Conversation

jumokeoladimeji
Copy link
Contributor

#93
I also fixed a failing test.

cgrayson
cgrayson requested changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The desired fix isn't specifically to make single letter accounts invalid, but to add support for the "matches pattern" operator (like string has, for example), so that users could create filters like that example case.

cgrayson
cgrayson approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

src/types/email.coffee
@@ -50,6 +50,7 @@ module.exports =
'does not include'
'is included in'
'is not included in'
'matches pattern'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we add an operator we usually want the negated operator, too. In this case that's 'does not match pattern'.

spec/email-spec.coffee Outdated
@@ -53,5 +53,4 @@ describe 'Email', ->
assert.equal parsed.raw, 'USER@domain.com'

it 'should have examples', ->
assert email.examples.length

assert email.examples.length
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude files when there's nothing but a trivial formatting change like this.

@jumokeoladimeji jumokeoladimeji merged commit c9799d0 into master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrayson cgrayson cgrayson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jumokeoladimeji @cgrayson