Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent changing host through params #1391

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Prevent changing host through params #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ransack/helpers/form_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def name
end

def url_options
@params.merge(
@params.except(:host).merge(
@options.except(:class, :data, :host).merge(
@search.context.search_key => search_and_sort_params))
end
Expand Down
8 changes: 8 additions & 0 deletions spec/ransack/helpers/form_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,14 @@ module Helpers
it { should_not match /href=".*foo/ }
end

describe "#sort_link ignores host in params" do
before { @controller.view_context.params[:host] = 'other_domain' }
subject { @controller.view_context.sort_link(Person.ransack, :name, controller: 'people') }

it { should match /href="\/people\?q/ }
it { should_not match /href=".*other_domain/ }
end

describe '#search_form_for with default format' do
subject { @controller.view_context
.search_form_for(Person.ransack) {} }
Expand Down