Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check type before sending #value message to predicate #1468

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jan 8, 2024

  1. Check type before sending #value message to predicate

    The previous implementation was giving for granted that every predicate
    respond  to `#value`, but that doesn't seem to be the case at least when
    having a `Arel::SelectManager`.
    
    by simply inverting the terms of the existing AND check we can fix the issue
    without introducing unknown side effects.
    
    In order to test the change, a new ransacker has been added to the Person model.
    spaghetticode committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e7c8250 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    c171fa2 View commit details
    Browse the repository at this point in the history