Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external cabs (.cab files not embedded in the msi) #4

Closed
activescott opened this issue Aug 9, 2013 · 2 comments
Closed

Support external cabs (.cab files not embedded in the msi) #4

activescott opened this issue Aug 9, 2013 · 2 comments

Comments

@activescott
Copy link
Owner

from https://code.google.com/p/lessmsi/issues/detail?id=7

Project Member Reported by activescott, Mar 18, 2010

What steps will reproduce the problem?

  1. Use WinSDK_x86.msi
  2. Extrac

What is the expected output? What do you see instead?
Should extract normally, but nothing happens.

At a minimum it should provide better error messages.

Mar 18, 2010 Delete comment #1 googlegroups.services@sanoys.com

  1. Download the Windows 7 SDK ISO from here:
    http://www.microsoft.com/downloads/details.aspx?FamilyID=71deb800-c591-4f97-a900-
    bea146e4fae1&displaylang=en
  2. Mount the ISO
  3. In lessmsi.exe open \Setup\WinSDK\WinSDK_x86.msi (notice external cab)
  4. Attempt to extract "hxds.dll"
  5. After clicking OK for the extract folder nothing happens and no errors are
    presented.

Thanks,
D.
Mar 18, 2010 Delete comment Project Member #2 activescott
Thanks for the details. Very helpful. I'm making this high priority. Will investigate next
time I work on the project.
Labels: -Priority-Medium Priority-High
Mar 18, 2010 Delete comment Project Member #3 activescott
(No comment was entered for this change.)
Status: Accepted
Mar 18, 2010 Delete comment Project Member #4 activescott
(No comment was entered for this change.)
Labels: Milestone-Release2.0
Mar 2, 2011 Delete comment Project Member #5 activescott
Note: See issue 9 which is related to this.

@acelent
Copy link
Contributor

acelent commented Dec 3, 2013

I've made a small change that supports external CAB files. It works for the exact case you describe, which only has one external cab, as well as for an MSI with multiple external CABs. I've tested with the latest Windows 7 SDK ISO.

Please take a look at acelent/lessmsi@a9a877d.

@activescott
Copy link
Owner Author

@acelent Thanks for the work here! Can you please issue a pull request? Also, we'll need some tests for this. If you can write the tests that will be great. If you don't have time/interest to add tests right away issue the pull request and I'll add a test when I have time.
Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants