-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract logic to DLL #21
Conversation
Moved "lib" and "bin" out of "src"
@bastianeicher thanks for the PR! I'll look at this closer as soon as I have time to spare. Probably tonight or tomorrow night. If you can investigate the build failures that would be great. If not, I'll investigate and resolve before I pull. I'll also make the ExpectedOutput path configurable or more resiliant. I planned on doing it at some point, just never had the need myself. |
Worked on this briefly tonight. Working on getting the builds to compile first then will work on lowercase assemblies, make unit tests work in different paths, misc code review. Initial build failures in xbuild seem to be due to mismatch configuration/platform changes in targets. x86 should be fine, but isn't used consistently across projects? Empty/invalid configs in some projects? |
…and failed build.
…n to compile (unit test still failing).
…ctuals build configs?
…is still failing (not setting an output filename for some reason).
I am continuing to work on getting a clean compile and unit tests working in the bastianeicher-master branch: https://github.com/activescott/lessmsi/compare/bastianeicher-master |
Well isn't that odd. Travis passed but xbuild still fails on my local mac.
Notice the /out:obj/Debug/ ... section. WTF. Different mono versions?? |
Sorry to hear the changes are causing so much trouble. I've often stumbled across fun xbuild bugs/inconsistencies in my own project (Windows as a dev machine, Linux as a build server). I noticed that you changed the I'll try compiling the code with xbuild 2.10.8.1 shortly. |
Well, turns out xbuild 2.10.* does not like the |
Cool, version of xbuild what I suspected when I was wrapping up last night. I will also fix the OutputPath that was my bad I expect to get back onto this tonight... Hopefully will get far enough along to get it pulled tonight! Thanks again! |
Turns out I have xbuild 3.2.0.0 on the mac I was trying to build with and the error is different from the above cited bug so it is unrelated. |
Okay! Installed xbuild 3.2.1 and it worked! Next!... |
Although I think there are some minor issues around, this is merged and I think this can be closed. I'll open new issues for any changes I can think of. Thanks for the commit @bastianeicher ! |
LessMsi-cli.exe
has the existingNDesk.Options
-based command-line handling (without the OpenGuiCommand).LessMsi-gui.exe
takes the first command-line argument (if any) and uses it as thedefaultInputFile
without any further processing.bin
directories in the project directories into a single sharedbin
alongside thesrc
directory to reduce the amount of DLL copying required in the build process.ExpectedOutput
CSVs are hardcoded to a different path than my local Git clone.See issue #19