UI-7417 - Handle nodes with missing content #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -180,6 +180,10 @@ const accumulateStructure = ({ | |||
| folders, | |||
| path: [...path, id], | |||
| }); | |||
| } else { | |||
| console.error( | |||
| `The 'structure' folder contains an object of id '${id}' that could not be identified (missing or corrupted entry in 'content'). Children of that object will be ignored.` | |||
There was a problem hiding this comment.
I get that we can warn about the missing entry in content here.
But if the entry is here, and just has a missing content, this is handled outside, isn't it ?
If so, I would remove the part about the corrupt content here.
There was a problem hiding this comment.
What I observed was that you would still attempt to resolve the structure of children of a corrupt node. Then, when trying to create the parent of that child in the new structure, you are not able to find the information about the parent in the legacy structure.
So you need this.
Co-authored-by: Antoine Tissier <ati@activeviam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it happens that bookmarks are missing the
contentattribute in theirContentEntry, the migration tool now reports it gracefully and does not go down these node'sstructure. Doing so would trigger an error when resolving the path of these children and assuming that their parent are folders.With no content we cannot determine the type of the node and are basically helpless.