UI-8056 - Introduce getMigrateFilters function

[eliasinho]

Description

Introduce a getMigrateFilters function, supposed to be generic, that:

• returns a migration function that takes a callback argument. This callback function handles the actual migration of the filters, the logic in it depending on which migration is done
• mutates contentServer and counters.
• handles error cases by mutating errorReport

In bin.ts, a curried migrateFilters function will be created thanks to getMigrateFilters and passed to migrate_fromVersion_to_toVersion. The global variables meant to be mutated are also defined at the level of bin.ts and are passed to migrate_fromVersion_to_toVersion.

In migrate_fromVersion_to_toVersion, the filters migration is handled in the callback passed to migrateFilters, passed in the arguments. migrate_fromVersion_to_toVersion returns a void.

[antoinetissier]

More arguments need to be passed to the callback (and therefore to the getMigrateXyz function in the first place): dataModels for all content types, and keysOfWidgetPluginsToRemove for widgets.
Let's add dataModels to getMigrateFilters already.

[antoinetissier]

Why this change ? It's more efficient to do the work only once outside the loop, and I don't see the potential mutations being a problem, since we're only mutating the content and the structure (and so not the files ancestry).

[eliasinho]

Yeah, good point, it's more efficient outside the loop, my bad!

[eliasinho]

More arguments need to be passed to the callback (and therefore to the getMigrateXyz function in the first place): dataModels for all content types, and keysOfWidgetPluginsToRemove for widgets.

Okay, I'll add them. Can you explain why we need them?

[antoinetissier]

More arguments need to be passed to the callback (and therefore to the getMigrateXyz function in the first place): dataModels for all content types, and keysOfWidgetPluginsToRemove for widgets.

Okay, I'll add them. Can you explain why we need them?

We need the dataModels for any operation including a cube lookup, which in particular includes almost any MDX manipulation.
We need the keysOfWidgetPluginsToRemove to allow callers to ignore some widgets such as custom ones.

You can see example in the migration from 4.3 to 5.0.

[antoinetissier]

The point is to pass it to the callback: it wouldn't be useful if we just put it in the signature.

But if you want let's just merge without the dataModels for now.
I have it ready on a subsequent branch, so we can add it from there.

[antoinetissier]

I pushed a commit to leave adding the dataModels out of the PR for now.
Looks good to me like this !