Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XLSX support, optional row validation, added SQLite insert_update_db #131

Merged
merged 1 commit into from Jul 2, 2013
Merged

Conversation

tylergannon
Copy link
Contributor

  1. Added xslx support through Roo gem.
    • Roo appears to be more fully featured than Spreadsheet, and it supports XLSX files whereas the latter does not. Other than that it seems to be a drop-in replacement.
  2. Made row validation optional on ExcelParser.
    • I was running into issues where it's no big deal for my script to be smart enough to skip invalid rows but the whole ETL job would barf because one row was missing a field. putting :validate => false in the parser options will skip row-level validation.
  3. Added SQLite3 to the insert_update_database destination. It works.
  4. The changes to engine.rb are for ActiveRecord 3.2.x, which will not allow mass-assignment unless expressly enabled on the model. This change seemed easier than modifying the model class ETL::Execution::Job since I didn't know what might break if I change that class around.

thbar added a commit that referenced this pull request Jul 2, 2013
	Added XLSX support, optional row validation, added SQLite insert_update_db
@thbar thbar merged commit 15ace62 into activewarehouse:master Jul 2, 2013
@thbar
Copy link
Member

thbar commented Jul 2, 2013

Thank you @tylergannon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants