Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CardAbout expand text functionality if text doesn't trigger line clamp #659

Conversation

tatianakharitonovich
Copy link
Contributor

@tatianakharitonovich tatianakharitonovich commented Jan 24, 2024

Contributor checklist


Description

This PR is related to #658 issue.

I tested it manually.

Related issue

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit a02c2e3
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/65b0cb60820a2b0008cf9beb
😎 Deploy Preview https://deploy-preview-659--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review January 24, 2024 18:58
@andrewtavis
Copy link
Member

Hey @tatianakharitonovich 👋 A quick note that I edited your commit message to check the box and put in the issue number appropriately :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really really great work here, @tatianakharitonovich 😊 Also wonderful to have consistent contributions from you at the start! If you've yet to join us in the discussions on Matrix, it'd be great to have you in there! The Development channel is a great place to ask questions, and is also where we put notifications like for our bi-weekly syncs. Next one is this Saturday, and it'd be great to have you!

@andrewtavis andrewtavis merged commit 89edfc0 into activist-org:main Jan 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants