Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe CORS configuration #24

Closed
johan-bjareholt opened this issue Mar 12, 2019 · 1 comment · Fixed by #31 or #53
Closed

Safe CORS configuration #24

johan-bjareholt opened this issue Mar 12, 2019 · 1 comment · Fixed by #31 or #53

Comments

@johan-bjareholt
Copy link
Member

rocket_cors now support regex in the origin configuration, we should use that to implement CORS safely. Maybe also add support for custom origin configurations in the config?

@ErikBjare
Copy link
Member

ErikBjare commented Aug 13, 2019

Some bad news: In Firefox, extensions do not use their ID in the extension URL, they use an installation-unique extension UUID (apparently to prevent fingerprinting).

They mention it here: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/web_accessible_resources


image


This means we have to use a moz-extension://* origin for Firefox users, this is not ideal as it would let any Firefox extension access the ActivityWatch database.

Seems we have yet another reason to start working on a proper authentication flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants