Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update actix dependencies to the latest betas #147

Closed
wants to merge 7 commits into from
Closed

update actix dependencies to the latest betas #147

wants to merge 7 commits into from

Conversation

DominicWrege
Copy link

@DominicWrege DominicWrege commented Jan 8, 2021

PR Type

Update

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

The goal was to updated all dependencies to work with the latest actix-web beta and fix all the tests.
There is one previews test failure in session::test::test_session_workflow which I did not fix.

@DominicWrege DominicWrege marked this pull request as draft January 8, 2021 23:41
@robjtede
Copy link
Member

robjtede commented Jan 8, 2021

this and #144 are gonna have to fight it out :P

@DominicWrege DominicWrege marked this pull request as ready for review January 12, 2021 00:32
@therealprof
Copy link

Hm, not being able to use actix-cors blocks me from testing the actix/actix-web beta.

@robjtede
Copy link
Member

you can use it with cargo git deps from this branch (using git = "{git_url}", rev = "{commit_hash}"

@robjtede robjtede marked this pull request as draft January 13, 2021 12:23
@therealprof
Copy link

@robjtede Good point, didn't think of that.

@therealprof
Copy link

OTOH it doesn't work without major magic since actix-cors is a workspace member and pseudo-virtual package of actix-extras and there's no git syntax for that.

@DominicWrege
Copy link
Author

DominicWrege commented Jan 13, 2021

@therealprof can please you be more specific about your issue? I created a little example project which uses the actix-cors git version.

@therealprof
Copy link

@therealprof can please you be more specific about your issue? I created a little example project which uses the actix-cors git version.

Hm, I tried:

actix-cors = { git="https://github.com/actix/actix-extras", rev="9f9690348be8224139c3672bbf4d8feb34393545"}

and it didn't work, your example does, using your repo it does work. Thanks!

@DominicWrege
Copy link
Author

DominicWrege commented Jan 13, 2021

Yep wrong branch/repo :)

@therealprof
Copy link

Any chance to get the versions bumped again? ;)

@DominicWrege
Copy link
Author

Any chance to get the versions bumped again? ;)

I am sorry, can you please explain what do you mean ?

@therealprof
Copy link

I am sorry, can you please explain what do you mean ?

There're new releases of various actix crates, so the Cargo.toml needs an update.

@fakeshadow
Copy link
Contributor

Newest release of beta crates have compat issue with actix-web v4 beta.1.
For now this PR better remain untouched on dep side until next actix-web beta release.
The CI fails for the same reason.

@DominicWrege
Copy link
Author

Agree.

@robjtede
Copy link
Member

#144 was merged. Thanks for your input regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants