Skip to content

Commit

Permalink
fix check external types
Browse files Browse the repository at this point in the history
  • Loading branch information
robjtede committed Nov 6, 2023
1 parent f632ef2 commit df12c10
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ jobs:
tool: cargo-check-external-types@0.1.10

- name: check external types
run: just check-external-types-all
run: just check-external-types-all +nightly-2023-10-10
12 changes: 6 additions & 6 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,27 +11,27 @@ doc-watch:
cargo watch -- RUSTDOCFLAGS="--cfg=docsrs" cargo +nightly doc --no-deps --workspace --features=rustls,openssl

# Check for unintentional external type exposure on all crates in workspace.
check-external-types-all:
check-external-types-all toolchain="+nightly":
#!/usr/bin/env bash
set -euo pipefail
exit=0
for f in $(find . -mindepth 2 -maxdepth 2 -name Cargo.toml | grep -vE "\-codegen/|\-derive/|\-macros/"); do
if ! just check-external-types-manifest "$f"; then exit=1; fi
if ! just check-external-types-manifest "$f" {{toolchain}}; then exit=1; fi
echo
echo
done
exit $exit

# Check for unintentional external type exposure on all crates in workspace.
check-external-types-all-table:
check-external-types-all-table toolchain="+nightly":
#!/usr/bin/env bash
set -euo pipefail
for f in $(find . -mindepth 2 -maxdepth 2 -name Cargo.toml | grep -vE "\-codegen/|\-derive/|\-macros/"); do
echo
echo "Checking for $f"
just check-external-types-manifest "$f" --output-format=markdown-table
just check-external-types-manifest "$f" {{toolchain}} --output-format=markdown-table
done

# Check for unintentional external type exposure on a crate.
check-external-types-manifest manifest_path *extra_args:
cargo +nightly check-external-types --manifest-path "{{manifest_path}}" {{extra_args}}
check-external-types-manifest manifest_path toolchain="+nightly" *extra_args="":
cargo {{toolchain}} check-external-types --manifest-path "{{manifest_path}}" {{extra_args}}

0 comments on commit df12c10

Please sign in to comment.