Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made new constructor for the Connection type public #439

Merged
merged 2 commits into from Jan 28, 2022
Merged

Made new constructor for the Connection type public #439

merged 2 commits into from Jan 28, 2022

Conversation

bmuddha
Copy link
Contributor

@bmuddha bmuddha commented Jan 28, 2022

PR Type

Fix

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

There's a crate called awc-uds which is used to add support for Unix Domain Sockets for awc. And it needs to construct connect::connection::Connection type when implementing actix_service::Service, after this PR, it's not possible to construct Connection anymore, as all the fields and constructor are made crate private.

Changelog

  • Expose actix_tls::connect::Connection::new

@robjtede robjtede merged commit 3e624b8 into actix:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants