Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ByteString::slice_ref #470

Merged
merged 2 commits into from Nov 7, 2022
Merged

Add ByteString::slice_ref #470

merged 2 commits into from Nov 7, 2022

Conversation

branchseer
Copy link
Contributor

@branchseer branchseer commented Nov 7, 2022 •
edited

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Add ByteString::slice_ref which can slice a ByteString into a new one with zero copy.

@branchseer branchseer marked this pull request as ready for review November 7, 2022 11:14
@robjtede
Copy link
Member

robjtede commented Nov 7, 2022

LGTM, don't worry about the CI failure.

@robjtede robjtede merged commit 363984a into actix:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@branchseer @robjtede