Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added suport to http crate 1.0 #508

Merged
merged 3 commits into from Dec 6, 2023
Merged

feat: added suport to http crate 1.0 #508

merged 3 commits into from Dec 6, 2023

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Dec 2, 2023 •
edited

PR Type

INSERT_PR_TYPE

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

@morenol morenol mentioned this pull request Dec 2, 2023
Open
5 tasks
@morenol morenol force-pushed the http-dependency branch 4 times, most recently from 540cb83 to 0b4bc90 Compare December 5, 2023 16:31
@robjtede
Copy link
Member

robjtede commented Dec 5, 2023 •
edited

For this crate, I say we can just implement it for both versions of the http under the existing feature flag.

@morenol morenol force-pushed the http-dependency branch 2 times, most recently from b3c524a to 71aa6a3 Compare December 5, 2023 18:10
@morenol morenol changed the title chore: update http dependency feat: added suport to http crate 1.0 Dec 5, 2023
@morenol
Copy link
Contributor Author

morenol commented Dec 5, 2023

For this crate, I say we can just implement it for both versions of the http under the existing feature flag.

Thanks for this suggestion, can you take a look now?

@robjtede
Copy link
Member

robjtede commented Dec 5, 2023

thanks for kicking this off 👍🏻

@robjtede robjtede added this pull request to the merge queue Dec 6, 2023
Merged via the queue into actix:master with commit 1945fa0 Dec 6, 2023
14 checks passed
@morenol morenol deleted the http-dependency branch December 6, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morenol @robjtede