This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Tighten HttpAuthentication::with_fn bound from FnMut to Fn. #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three constructor functions for
HttpAuthentication
only requiresF: FnMut
. However, the constructed instances are only usable whenF: Fn
. This is unfortunate for closures, since the passed closure will be inferred to be onlyFnMut
when it only captures immutably.Technically it's a breaking change, but as it's actually unusable without
F: Fn
, I'd think it's considered a bugfix. If this is unsuitable, I'll prepare another PR that introducesHttpAuthentication::with_fn2
etc.