Skip to content

Commit

Permalink
rename header generator macros
Browse files Browse the repository at this point in the history
  • Loading branch information
robjtede committed Apr 16, 2021
1 parent 845c02c commit 8d88a0a
Show file tree
Hide file tree
Showing 20 changed files with 395 additions and 397 deletions.
10 changes: 5 additions & 5 deletions src/http/header/accept.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use mime::Mime;
use super::{qitem, QualityItem};
use crate::http::header;

crate::header! {
crate::__define_common_header! {
/// `Accept` header, defined in [RFC7231](http://tools.ietf.org/html/rfc7231#section-5.3.2)
///
/// The `Accept` header field can be used by user agents to specify
Expand Down Expand Up @@ -81,14 +81,14 @@ crate::header! {

test_accept {
// Tests from the RFC
test_header!(
crate::__common_header_test!(
test1,
vec![b"audio/*; q=0.2, audio/basic"],
Some(Accept(vec![
QualityItem::new("audio/*".parse().unwrap(), q(200)),
qitem("audio/basic".parse().unwrap()),
])));
test_header!(
crate::__common_header_test!(
test2,
vec![b"text/plain; q=0.5, text/html, text/x-dvi; q=0.8, text/x-c"],
Some(Accept(vec![
Expand All @@ -100,13 +100,13 @@ crate::header! {
qitem("text/x-c".parse().unwrap()),
])));
// Custom tests
test_header!(
crate::__common_header_test!(
test3,
vec![b"text/plain; charset=utf-8"],
Some(Accept(vec![
qitem(mime::TEXT_PLAIN_UTF_8),
])));
test_header!(
crate::__common_header_test!(
test4,
vec![b"text/plain; charset=utf-8; q=0.5"],
Some(Accept(vec![
Expand Down
4 changes: 2 additions & 2 deletions src/http/header/accept_charset.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use super::{Charset, QualityItem, ACCEPT_CHARSET};

crate::header! {
crate::__define_common_header! {
/// `Accept-Charset` header, defined in
/// [RFC7231](http://tools.ietf.org/html/rfc7231#section-5.3.3)
///
Expand Down Expand Up @@ -57,6 +57,6 @@ crate::header! {

test_accept_charset {
// Test case from RFC
test_header!(test1, vec![b"iso-8859-5, unicode-1-1;q=0.8"]);
crate::__common_header_test!(test1, vec![b"iso-8859-5, unicode-1-1;q=0.8"]);
}
}
10 changes: 5 additions & 5 deletions src/http/header/accept_encoding.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ header! {

test_accept_encoding {
// From the RFC
test_header!(test1, vec![b"compress, gzip"]);
test_header!(test2, vec![b""], Some(AcceptEncoding(vec![])));
test_header!(test3, vec![b"*"]);
crate::__common_header_test!(test1, vec![b"compress, gzip"]);
crate::__common_header_test!(test2, vec![b""], Some(AcceptEncoding(vec![])));
crate::__common_header_test!(test3, vec![b"*"]);
// Note: Removed quality 1 from gzip
test_header!(test4, vec![b"compress;q=0.5, gzip"]);
crate::__common_header_test!(test4, vec![b"compress;q=0.5, gzip"]);
// Note: Removed quality 1 from gzip
test_header!(test5, vec![b"gzip, identity; q=0.5, *;q=0"]);
crate::__common_header_test!(test5, vec![b"gzip, identity; q=0.5, *;q=0"]);
}
}
9 changes: 5 additions & 4 deletions src/http/header/accept_language.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
use super::{QualityItem, ACCEPT_LANGUAGE};
use language_tags::LanguageTag;

crate::header! {
use super::{QualityItem, ACCEPT_LANGUAGE};

crate::__define_common_header! {
/// `Accept-Language` header, defined in
/// [RFC7231](http://tools.ietf.org/html/rfc7231#section-5.3.5)
///
Expand Down Expand Up @@ -56,9 +57,9 @@ crate::header! {

test_accept_language {
// From the RFC
test_header!(test1, vec![b"da, en-gb;q=0.8, en;q=0.7"]);
crate::__common_header_test!(test1, vec![b"da, en-gb;q=0.8, en;q=0.7"]);
// Own test
test_header!(
crate::__common_header_test!(
test2, vec![b"en-US, en; q=0.5, fr"],
Some(AcceptLanguage(vec![
qitem("en-US".parse().unwrap()),
Expand Down
10 changes: 5 additions & 5 deletions src/http/header/allow.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use actix_http::http::Method;
use crate::http::header;
use actix_http::http::Method;

crate::header! {
crate::__define_common_header! {
/// `Allow` header, defined in [RFC7231](http://tools.ietf.org/html/rfc7231#section-7.4.1)
///
/// The `Allow` header field lists the set of methods advertised as
Expand Down Expand Up @@ -49,12 +49,12 @@ crate::header! {

test_allow {
// From the RFC
test_header!(
crate::__common_header_test!(
test1,
vec![b"GET, HEAD, PUT"],
Some(HeaderField(vec![Method::GET, Method::HEAD, Method::PUT])));
// Own tests
test_header!(
crate::__common_header_test!(
test2,
vec![b"OPTIONS, GET, PUT, POST, DELETE, HEAD, TRACE, CONNECT, PATCH"],
Some(HeaderField(vec![
Expand All @@ -67,7 +67,7 @@ crate::header! {
Method::TRACE,
Method::CONNECT,
Method::PATCH])));
test_header!(
crate::__common_header_test!(
test3,
vec![b""],
Some(HeaderField(Vec::<Method>::new())));
Expand Down
6 changes: 3 additions & 3 deletions src/http/header/cache_control.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ use crate::http::header;
#[derive(PartialEq, Clone, Debug)]
pub struct CacheControl(pub Vec<CacheDirective>);

__hyper__deref!(CacheControl => Vec<CacheDirective>);
crate::__common_header_deref!(CacheControl => Vec<CacheDirective>);

//TODO: this could just be the header! macro
// TODO: this could just be the __define_common_header! macro
impl Header for CacheControl {
fn name() -> header::HeaderName {
header::CACHE_CONTROL
Expand All @@ -75,7 +75,7 @@ impl Header for CacheControl {

impl fmt::Display for CacheControl {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
fmt_comma_delimited(f, &self[..])
fmt_comma_delimited(f, &self.0[..])
}
}

Expand Down
6 changes: 3 additions & 3 deletions src/http/header/content_language.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use super::{QualityItem, CONTENT_LANGUAGE};
use language_tags::LanguageTag;

crate::header! {
crate::__define_common_header! {
/// `Content-Language` header, defined in
/// [RFC7231](https://tools.ietf.org/html/rfc7231#section-3.1.3.2)
///
Expand Down Expand Up @@ -52,7 +52,7 @@ crate::header! {
(ContentLanguage, CONTENT_LANGUAGE) => (QualityItem<LanguageTag>)+

test_content_language {
test_header!(test1, vec![b"da"]);
test_header!(test2, vec![b"mi, en"]);
crate::__common_header_test!(test1, vec![b"da"]);
crate::__common_header_test!(test2, vec![b"mi, en"]);
}
}
24 changes: 12 additions & 12 deletions src/http/header/content_range.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,65 +6,65 @@ use super::{
HeaderValue, IntoHeaderValue, InvalidHeaderValue, Writer, CONTENT_RANGE,
};

crate::header! {
crate::__define_common_header! {
/// `Content-Range` header, defined in
/// [RFC7233](http://tools.ietf.org/html/rfc7233#section-4.2)
(ContentRange, CONTENT_RANGE) => [ContentRangeSpec]

test_content_range {
test_header!(test_bytes,
crate::__common_header_test!(test_bytes,
vec![b"bytes 0-499/500"],
Some(ContentRange(ContentRangeSpec::Bytes {
range: Some((0, 499)),
instance_length: Some(500)
})));

test_header!(test_bytes_unknown_len,
crate::__common_header_test!(test_bytes_unknown_len,
vec![b"bytes 0-499/*"],
Some(ContentRange(ContentRangeSpec::Bytes {
range: Some((0, 499)),
instance_length: None
})));

test_header!(test_bytes_unknown_range,
crate::__common_header_test!(test_bytes_unknown_range,
vec![b"bytes */500"],
Some(ContentRange(ContentRangeSpec::Bytes {
range: None,
instance_length: Some(500)
})));

test_header!(test_unregistered,
crate::__common_header_test!(test_unregistered,
vec![b"seconds 1-2"],
Some(ContentRange(ContentRangeSpec::Unregistered {
unit: "seconds".to_owned(),
resp: "1-2".to_owned()
})));

test_header!(test_no_len,
crate::__common_header_test!(test_no_len,
vec![b"bytes 0-499"],
None::<ContentRange>);

test_header!(test_only_unit,
crate::__common_header_test!(test_only_unit,
vec![b"bytes"],
None::<ContentRange>);

test_header!(test_end_less_than_start,
crate::__common_header_test!(test_end_less_than_start,
vec![b"bytes 499-0/500"],
None::<ContentRange>);

test_header!(test_blank,
crate::__common_header_test!(test_blank,
vec![b""],
None::<ContentRange>);

test_header!(test_bytes_many_spaces,
crate::__common_header_test!(test_bytes_many_spaces,
vec![b"bytes 1-2/500 3"],
None::<ContentRange>);

test_header!(test_bytes_many_slashes,
crate::__common_header_test!(test_bytes_many_slashes,
vec![b"bytes 1-2/500/600"],
None::<ContentRange>);

test_header!(test_bytes_many_dashes,
crate::__common_header_test!(test_bytes_many_dashes,
vec![b"bytes 1-2-3/500"],
None::<ContentRange>);

Expand Down
4 changes: 2 additions & 2 deletions src/http/header/content_type.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use super::CONTENT_TYPE;
use mime::Mime;

crate::header! {
crate::__define_common_header! {
/// `Content-Type` header, defined in
/// [RFC7231](http://tools.ietf.org/html/rfc7231#section-3.1.1.5)
///
Expand Down Expand Up @@ -52,7 +52,7 @@ crate::header! {
(ContentType, CONTENT_TYPE) => [Mime]

test_content_type {
test_header!(
crate::__common_header_test!(
test1,
vec![b"text/html"],
Some(HeaderField(mime::TEXT_HTML)));
Expand Down
4 changes: 2 additions & 2 deletions src/http/header/date.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use super::{HttpDate, DATE};
use std::time::SystemTime;

crate::header! {
crate::__define_common_header! {
/// `Date` header, defined in [RFC7231](http://tools.ietf.org/html/rfc7231#section-7.1.1.2)
///
/// The `Date` header field represents the date and time at which the
Expand Down Expand Up @@ -32,7 +32,7 @@ crate::header! {
(Date, DATE) => [HttpDate]

test_date {
test_header!(test1, vec![b"Tue, 15 Nov 1994 08:12:31 GMT"]);
crate::__common_header_test!(test1, vec![b"Tue, 15 Nov 1994 08:12:31 GMT"]);
}
}

Expand Down
32 changes: 16 additions & 16 deletions src/http/header/etag.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use super::{EntityTag, ETAG};

crate::header! {
crate::__define_common_header! {
/// `ETag` header, defined in [RFC7232](http://tools.ietf.org/html/rfc7232#section-2.3)
///
/// The `ETag` header field in a response provides the current entity-tag
Expand Down Expand Up @@ -50,50 +50,50 @@ crate::header! {

test_etag {
// From the RFC
test_header!(test1,
crate::__common_header_test!(test1,
vec![b"\"xyzzy\""],
Some(ETag(EntityTag::new(false, "xyzzy".to_owned()))));
test_header!(test2,
crate::__common_header_test!(test2,
vec![b"W/\"xyzzy\""],
Some(ETag(EntityTag::new(true, "xyzzy".to_owned()))));
test_header!(test3,
crate::__common_header_test!(test3,
vec![b"\"\""],
Some(ETag(EntityTag::new(false, "".to_owned()))));
// Own tests
test_header!(test4,
crate::__common_header_test!(test4,
vec![b"\"foobar\""],
Some(ETag(EntityTag::new(false, "foobar".to_owned()))));
test_header!(test5,
crate::__common_header_test!(test5,
vec![b"\"\""],
Some(ETag(EntityTag::new(false, "".to_owned()))));
test_header!(test6,
crate::__common_header_test!(test6,
vec![b"W/\"weak-etag\""],
Some(ETag(EntityTag::new(true, "weak-etag".to_owned()))));
test_header!(test7,
crate::__common_header_test!(test7,
vec![b"W/\"\x65\x62\""],
Some(ETag(EntityTag::new(true, "\u{0065}\u{0062}".to_owned()))));
test_header!(test8,
crate::__common_header_test!(test8,
vec![b"W/\"\""],
Some(ETag(EntityTag::new(true, "".to_owned()))));
test_header!(test9,
crate::__common_header_test!(test9,
vec![b"no-dquotes"],
None::<ETag>);
test_header!(test10,
crate::__common_header_test!(test10,
vec![b"w/\"the-first-w-is-case-sensitive\""],
None::<ETag>);
test_header!(test11,
crate::__common_header_test!(test11,
vec![b""],
None::<ETag>);
test_header!(test12,
crate::__common_header_test!(test12,
vec![b"\"unmatched-dquotes1"],
None::<ETag>);
test_header!(test13,
crate::__common_header_test!(test13,
vec![b"unmatched-dquotes2\""],
None::<ETag>);
test_header!(test14,
crate::__common_header_test!(test14,
vec![b"matched-\"dquotes\""],
None::<ETag>);
test_header!(test15,
crate::__common_header_test!(test15,
vec![b"\""],
None::<ETag>);
}
Expand Down
4 changes: 2 additions & 2 deletions src/http/header/expires.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use super::{HttpDate, EXPIRES};

crate::header! {
crate::__define_common_header! {
/// `Expires` header, defined in [RFC7234](http://tools.ietf.org/html/rfc7234#section-5.3)
///
/// The `Expires` header field gives the date/time after which the
Expand Down Expand Up @@ -36,6 +36,6 @@ crate::header! {

test_expires {
// Test case from RFC
test_header!(test1, vec![b"Thu, 01 Dec 1994 16:00:00 GMT"]);
crate::__common_header_test!(test1, vec![b"Thu, 01 Dec 1994 16:00:00 GMT"]);
}
}

0 comments on commit 8d88a0a

Please sign in to comment.