actix-web-actors: take the internal buffer when yielding (#3369)

* actix-web-actors: take the internal buffer when yielding * actix-web-actors: Add CHANGES entry re: taking buffer
actix · Jun 9, 2024 · f7646bc · f7646bc
1 parent 8018983
commit f7646bc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/actix-web-actors/CHANGES.md b/actix-web-actors/CHANGES.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Take the encoded buffer when yielding bytes in the response stream rather than splitting the buffer, reducing memory use
 - Minimum supported Rust version (MSRV) is now 1.72.
 
 ## 4.3.0

diff --git a/actix-web-actors/src/ws.rs b/actix-web-actors/src/ws.rs
@@ -710,7 +710,7 @@ where
         }
 
         if !this.buf.is_empty() {
-            Poll::Ready(Some(Ok(this.buf.split().freeze())))
+            Poll::Ready(Some(Ok(std::mem::take(&mut this.buf).freeze())))
         } else if this.fut.alive() && !this.closed {
             Poll::Pending
         } else {