Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance transfer of actix-web-httpauth crate #1257

Closed
svartalf opened this issue Jan 5, 2020 · 12 comments
Closed

Maintenance transfer of actix-web-httpauth crate #1257

svartalf opened this issue Jan 5, 2020 · 12 comments

Comments

@svartalf
Copy link
Contributor

svartalf commented Jan 5, 2020

I have this actix-web-httpauth crate, which provides headers and extractors for HTTP Authorization routines; right now it supports only actix-web = "^1", but there is a PR for actix-web 2.x, so it should not be a big problem to update it quickly.

Yet, I don't think that I will be able to allocate time to support it properly in a nearby future, so I want to handle the bus factor here and transfer the maintenance; that includes moving the repository and adding crate maintainers at crates.io.

I would prefer to transfer it to https://github.com/actix org directly if it is okay with the Actix Team, but I'm open to suggestions too.

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 5, 2020

@actix/contributors

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 5, 2020

I am happy to move it to actix org, but someone should take formal maintainer role

@JohnTitor
Copy link
Member

I'm available to maintain that crate and help some work. (nice work @svartalf!)

@svartalf
Copy link
Contributor Author

svartalf commented Jan 5, 2020

@fafhrd91 great to hear! As far as I understand, nothing stops us to start the process?

@JohnTitor it seems that crates.io requires from user to be a part of github organization in order to add github:actix:owners owner to the crate, so I can add you as a crate owner and you will handle any ownership issues from there; is it okay with you?

@JohnTitor
Copy link
Member

so I can add you as a crate owner and you will handle any ownership issues from there; is it okay with you?

Sure thing 👍

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 6, 2020

@svartalf yes, just move it to actix org

@JohnTitor
Copy link
Member

@svartalf AFAIK, transfering repo to org also needs permission to create a repo in the org. If so, could you transfer repo to @fafhrd91 or me?

@svartalf
Copy link
Contributor Author

svartalf commented Jan 6, 2020

@JohnTitor yeah, you are right, I can't transfer repo to actix org directly, so I requested transfer to you and added you as a crate owner also (there should be a pending invite in your crates.io profile somewhere)

@JohnTitor
Copy link
Member

Okay, transfering(moving repo and setting crate owner on crates.io) seems successful.

@fafhrd91 could you modify permissions for the repo? I cannot do because I'm not an org owner.

And @svartalf, thanks again for your great work!

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 6, 2020

done

@JohnTitor
Copy link
Member

So, all work is done?

@svartalf
Copy link
Contributor Author

svartalf commented Jan 6, 2020

@JohnTitor it seems so. Feel free to contact me in case we forgot about something :)
Thank you for handling this crate, it would be a pity to abandon it

@svartalf svartalf closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants