Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actix-test: allow dynamic port setting #2960

Merged
merged 4 commits into from Feb 26, 2023
Merged

actix-test: allow dynamic port setting #2960

merged 4 commits into from Feb 26, 2023

Conversation

kristian1108
Copy link
Contributor

@kristian1108 kristian1108 commented Jan 6, 2023 •
edited

PR Type

Features

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

This is a quick change to allow the user to set a port instead of forcing a random assignment every time.

this is a tiny thing that I need in my own project. Might be nice for others.

@kristian1108 kristian1108 changed the title allow dynamic port setting actix-test: allow dynamic port setting Jan 6, 2023
@robjtede robjtede added B-semver-minor A-test-server project: test-server labels Jan 6, 2023
@robjtede robjtede requested a review from a team January 7, 2023 09:05
@robjtede
Copy link
Member

robjtede commented Jan 7, 2023

Please document the new method. See CHANGES.md in any crate folder for examples of what to add.

@kristian1108
Copy link
Contributor Author

Please document the new method. See CHANGES.md in any crate folder for examples of what to add.

Added a line, let me know if that's not sufficient or in the wrong place. Thanks!

@robjtede robjtede modified the milestone: actix-web v4.3 Jan 21, 2023
@robjtede robjtede enabled auto-merge (squash) February 26, 2023 03:57
@robjtede
Copy link
Member

robjtede commented Feb 26, 2023 •
edited

Thanks for your contribution! Will get it released after CI pass and merge.

@robjtede robjtede merged commit fbfff3e into actix:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
A-test-server project: test-server B-semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kristian1108 @robjtede @JohnTitor