Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dependency h2 #3071

Closed
daniel-pfeiffer opened this issue Jul 14, 2023 · 1 comment · Fixed by #3072
Closed

Unnecessary dependency h2 #3071

daniel-pfeiffer opened this issue Jul 14, 2023 · 1 comment · Fixed by #3072
Assignees
Labels
A-web project: actix-web C-chore Category: chore

Comments

@daniel-pfeiffer
Copy link

daniel-pfeiffer commented Jul 14, 2023

Context

For a backend on localhost, I do not need HTTP/2. But neither of these prevents it from being added:

# not directly needed, testing it's not a failure of a-web forwarding features
actix-http = { version = "*", default-features = false }
actix-web = { version = "*", default-features = false, features = ["macros"] }

Your Environment

Rust 1.71 actix-web v4.3.1 actix-http v3.3.1

@robjtede robjtede self-assigned this Jul 17, 2023
@robjtede robjtede added C-chore Category: chore A-web project: actix-web labels Jul 17, 2023
@robjtede
Copy link
Member

I've reverted this change because I neglected to test it properly before pushing. We actually need h2 for the auto-h2c features even when TLS is not enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web C-chore Category: chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants